Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add ANGULAR_PACKAGE to snapshot builds #31900

Closed
wants to merge 2 commits into from
Closed

ci: Add ANGULAR_PACKAGE to snapshot builds #31900

wants to merge 2 commits into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Jul 30, 2019

Ivy snapshots no longer contain metadata.json which breaks the detection logic for
Angular Package Format (APF) in npm/yarn install.
This PR adds ANGULAR_PACAKGE as a magic file to denote APF.
See bazelbuild/rules_nodejs#927

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau
ci: Add ANGULAR_PACKAGE to snapshot builds
53ac42d 
Ivy snapshots no longer contain metadata.json which breaks the detection logic for
Angular Package Format (APF) in npm/yarn install.
This PR adds ANGULAR_PACAKGE as a magic file to denote APF.
See bazelbuild/rules_nodejs#927
@kyliau kyliau added area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release labels Jul 30, 2019
@kyliau kyliau requested a review from alexeagle July 30, 2019 00:00
@kyliau kyliau requested a review from a team as a code owner July 30, 2019 00:00
@ngbot ngbot bot added this to the needsTriage milestone Jul 30, 2019
@kyliau kyliau mentioned this pull request Jul 30, 2019
Closed
12 tasks
@gkalpak
Copy link
Member

gkalpak commented Jul 30, 2019

But we still need a solution for 3rd-party packages, once we start recommending publishing packages built for ivy, right? Is this tracked somewhere (e.g. a Jira ticket)?

gkalpak
gkalpak approved these changes Jul 30, 2019
View reviewed changes
scripts/ci/publish-build-artifacts.sh Outdated
@@ -70,6 +70,7 @@ function publishRepo {
fi
echo `date` > $REPO_DIR/BUILD_INFO
echo $SHA >> $REPO_DIR/BUILD_INFO
echo 'This file is used by the npm/yarn_install rule to detect APF' > $REPO_DIR/ANGULAR_PACKAGE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a link to some more info (e.g. an issue on rules_nodejs with an explanation) or a comment explaining that this is due to the absence of metadata.json files under ivy would be helpful for posterity 😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this only affects snapshots pushed to GH. should this file also appear in any npm packages we build? Will Angular publish ivy-only release artifacts anytime?

@gregmagolan gregmagolan mentioned this pull request Aug 15, 2019
Closed
@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Aug 29, 2019
@alexeagle
Copy link
Contributor

FYI I added the merge label, I think this was just stuck?

@mhevery mhevery closed this in 2b28b91 Aug 29, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@kyliau @sabeersulaiman
ci: Add ANGULAR_PACKAGE to snapshot builds (angular#31900)
7db2c3a 
Ivy snapshots no longer contain metadata.json which breaks the detection logic for
Angular Package Format (APF) in npm/yarn install.
This PR adds ANGULAR_PACAKGE as a magic file to denote APF.
See bazelbuild/rules_nodejs#927

PR Close angular#31900
@gregmagolan gregmagolan mentioned this pull request Sep 9, 2019
Merged
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@kyliau @arnehoek
ci: Add ANGULAR_PACKAGE to snapshot builds (angular#31900)
61ae7c1 
Ivy snapshots no longer contain metadata.json which breaks the detection logic for
Angular Package Format (APF) in npm/yarn install.
This PR adds ANGULAR_PACAKGE as a magic file to denote APF.
See bazelbuild/rules_nodejs#927

PR Close angular#31900
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2019
@kyliau kyliau deleted the publish_snapshot branch October 16, 2019 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kyliau @gkalpak @alexeagle @googlebot